Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Explorer: indentation at root has changed #66580

Closed
bpasero opened this issue Jan 16, 2019 · 7 comments
Closed

New Explorer: indentation at root has changed #66580

bpasero opened this issue Jan 16, 2019 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded

Comments

@bpasero
Copy link
Member

bpasero commented Jan 16, 2019

Refs: #66485

It looks like the new explorer is no longer nicely aligned with the title:

image

image

@bpasero
Copy link
Member Author

bpasero commented Jan 16, 2019

@joaomoreno I also think the spacing from twistie to label has increased.

@isidorn
Copy link
Contributor

isidorn commented Jan 16, 2019

The indent has changed and became more compact. I personally do not mind this.
While it would be cool to use less space between twistie and element as before.
@joaomoreno I think all the trees should be the same and this shuold not be configurable.

@isidorn isidorn added this to the December/January 2019 milestone Jan 16, 2019
@bpasero
Copy link
Member Author

bpasero commented Jan 16, 2019

At least visually I would align the tree with the label of the view as before. Not sure about indentation within the tree. A more compact form seems better to me.

@shreeve
Copy link
Contributor

shreeve commented Jan 16, 2019

@bpasero - The more compact indentation level (10px per level) makes it hard to see the nesting.

abstracttree ts vscode-official 2019-01-16 02-38-40

How hard would it be to make this a user configuration setting? It's currently just a hard coded value of 10 in the code. Could you make it something like explorer.indentPixels or something like that?

abstracttree ts vscode-official 2019-01-16 02-43-14

@joaomoreno
Copy link
Member

The new indentation was an arbitrary value set by me. I will get it the same as the old tree.

@shreeve makes a good point, so @isidorn please create a separate issue for that if you agree.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues labels Jan 16, 2019
@isidorn
Copy link
Contributor

isidorn commented Jan 16, 2019

@joaomoreno yeah I agree. Though should this for every tree or only for explorer?
I think for every tree. So we should call it something like tree.indentPixels
Created #66605

@shreeve
Copy link
Contributor

shreeve commented Jan 16, 2019 via email

@bpasero bpasero added the verified Verification succeeded label Jan 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants