Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file explorer indentation levels #66579

Closed

Conversation

shreeve
Copy link
Contributor

@shreeve shreeve commented Jan 16, 2019

When looking at directories and files in the file explorer panel, the default indentation level is 12px. For many users, this default is not big enough and causes the nesting levels of the directories and files to be hard to figure out.

This patch simply increases the default file explorer indentation from 12px to 20px, yielding a much easier-on-the-eyes view of the files. Perhaps this value could go into a user setting and become configurable. Making this change directly in the code is much better than hacks such as slapping additional nasty css to the end of the vs/workbench/workbench.main.css file (which causes VS Code to complain that the installation has become corrupt).

On the image below, the left is the default and the right is what this change produces (ie - a visually more helpful level of indentation):

indent levels

The prior default of 12px has created a litany of issues on GitHub with users requesting changes to this default value for the file explorer. Setting the value to 20px feels significantly better, but perhaps this value could go into a user setting also.
@shreeve
Copy link
Contributor Author

shreeve commented Jan 16, 2019

The following animated GIF shows how the hierarchy grows and shrinks based on the value of the indent level. This screen capture was made using the older css hacks to adjust the indent level, whereas this current pull request directly updates the indent level in the code (and is thus much cleaner). However, this is included to show what the various sizes look like.

explorer-icons

@shreeve
Copy link
Contributor Author

shreeve commented Jan 16, 2019

Ah, just saw this (New Explorer: indentation at root has changed #66580)!

@isidorn
Copy link
Contributor

isidorn commented Jan 16, 2019

Thanks for your PR, however we will discuss the issue here #66580
You also did a PR against an old tree so I am closing this as we do not plan to merge it in. Now we are using a new tree.

@isidorn isidorn closed this Jan 16, 2019
@shreeve
Copy link
Contributor Author

shreeve commented Jan 16, 2019

@isidorn - Sounds GREAT! Thank you. I'm looking forward to using the new tree. Loving VS Code!

@isidorn
Copy link
Contributor

isidorn commented Jan 16, 2019

Glad to hear.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants