Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP syntax bug #66809

Closed
omochi opened this issue Jan 20, 2019 · 2 comments
Closed

PHP syntax bug #66809

omochi opened this issue Jan 20, 2019 · 2 comments
Assignees
@roblourens
Labels
php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@omochi
Copy link

omochi commented Jan 20, 2019

https://github.com/Microsoft/vscode/blob/772aaf777a2e6b50c5c2e53da1a0955d2cb73a4d/extensions/php/syntaxes/php.tmLanguage.json#L2698-L2701

It should be match not begin
@vscodebot
Copy link

vscodebot bot commented Jan 20, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the php PHP support issues label Jan 20, 2019
@roblourens
Copy link
Member

Not sure, filed atom/language-php#351 upstream

@roblourens roblourens added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jan 21, 2019
@omochi omochi mentioned this issue Jan 26, 2019
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omochi @roblourens