-
Notifications
You must be signed in to change notification settings - Fork 64
XML syntax definition problem #96
Comments
From @omochi on January 19, 2019 17:24 Oh, I found more. should be:
|
I recorded video. https://www.youtube.com/watch?v=UeCwolx7oW0&feature=youtu.be First issue: Second issue: VSCode process |
Thanks @omochi -
It looks like your example is: <%-- --%> I think those are JSP comments, not XML comments? In Atom, if I set the language to JSP the closing Let me know if I'm misunderstanding something here.
Your example here is: <!-- -- --> Related to the PR above, I believe this is already reported here: #91 |
@rsese I just reports about syntax of grammar file. report 1See this current code.
language-xml/grammars/xml.cson Lines 404 to 411 in 7bc75df
So it should be this.
Because JSP mode works correctly, JSP syntax is written as so.
report 2current definition is.
language-xml/grammars/xml.cson Lines 420 to 425 in 7bc75df
I think that to replace
Because this block is intended to match |
More information about report (2). I reported same concept for PHP syntax. They accept it and make PR to patch this. This PR is also reviewed by @rsese . I say same things. |
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
atom#96 already provides all the details about the issues fixed here. atom#87 (comment) has the correct code but merge included some extra indent which causes the rule not to work properly. In relation with atom#91, a `begin` without `end` or `while` was added but this is not valid as `begin` should always have a corresponding `end` or `while`. `match` should be used instead of `begin`
From @omochi on January 19, 2019 17:0
I may found bug of syntax.
https://github.com/Microsoft/vscode/blob/10a1d2a50a2882f5ae85bdb51eb04d3064fb9de9/extensions/xml/syntaxes/xml.tmLanguage.json#L354-L363
It should be:
Copied from original issue: microsoft/vscode#66776
The text was updated successfully, but these errors were encountered: