Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of relative paths for git.ignoredRepositories #76892

Closed
chrisdias opened this issue Jul 8, 2019 · 9 comments · Fixed by #83466
Closed

Add support of relative paths for git.ignoredRepositories #76892

chrisdias opened this issue Jul 8, 2019 · 9 comments · Fixed by #83466
Assignees
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@chrisdias
Copy link
Member

chrisdias commented Jul 8, 2019

Originally posted by @r44083 in #47890 (comment) pulling this up into an issue rather than a comment in a merged PR

Hi, could you please add support of relative git.ignoredRepositories path? So it could be possible to add ignored repository in the following way:

"git.ignoredRepositories": ["./openwrt"]
or 
"git.ignoredRepositories": ["${workspaceFolder}/openwrt"]

instead of

"git.ignoredRepositories": ["/home/username/some/absolute/path/openwrt"]
@vscodebot vscodebot bot added the git GIT issues label Jul 8, 2019
@joaomoreno joaomoreno added feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Jul 11, 2019
@joaomoreno joaomoreno added this to the Backlog milestone Jul 11, 2019
@joaomoreno joaomoreno removed their assignment Jul 11, 2019
@mushtaqak
Copy link

@joaomoreno I am interested in fixing this issue, I will put up a PR shortly.

@abhinuvpitale
Copy link

@mushtaqak are you working on this, if not lmk, I ll take it up

@mushtaqak
Copy link

@abhinuvpitale I hadn't started on this. If you are interested then please feel free to take it up. (I smh didn't get the notification of thumb-up emoji from Jao Moreneo)

@abhinuvpitale
Copy link

let me give it a shot then

@abhinuvpitale
Copy link

@joaomoreno what would be a good place to start?

@adityakaria
Copy link

@abhinuvpitale are you still working on this? If not, I'd like to try my hand it.
Ps: I'm new to this repository, and this seems like a good place to start.

@abhinuvpitale
Copy link

@adityakaria go for it!

@joaomoreno joaomoreno self-assigned this Oct 9, 2019
@Wowol
Copy link
Contributor

Wowol commented Oct 22, 2019

Hi, @adityakaria, are you still working on this? If not, I'll be glad to take it.

@joaomoreno
Copy link
Member

joaomoreno commented Nov 29, 2019

Verification: The chosen syntax is "git.ignoredRepositories": ["./openwrt"] and it means relative from any of the workspace folders.

@jrieken jrieken added the verified Verification succeeded label Dec 4, 2019
@joaomoreno joaomoreno added the on-release-notes Issue/pull request mentioned in release notes label Dec 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
7 participants