Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of EXT_HOST_CREATION_DELAY hacks in terminal #77655

Closed
Tyriar opened this issue Jul 19, 2019 · 3 comments
Closed

Get rid of EXT_HOST_CREATION_DELAY hacks in terminal #77655

Tyriar opened this issue Jul 19, 2019 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues terminal Integrated terminal issues
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 19, 2019

This could be avoided by more messages between ext host and main
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Jul 19, 2019
@Tyriar Tyriar added this to the Backlog milestone Jul 19, 2019
@Tyriar Tyriar self-assigned this Jul 19, 2019
Tyriar referenced this issue Jul 19, 2019
@Tyriar
Fix start cb in CustomExecution2
48e7c6d 
Fixes #77428
@Tyriar Tyriar modified the milestones: Backlog, July 2019 Jul 26, 2019
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed debt Code quality issues labels Jul 26, 2019
@Tyriar Tyriar modified the milestones: July 2019, Backlog Jul 27, 2019
@Tyriar Tyriar added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Sep 13, 2019
@Tyriar Tyriar mentioned this issue Sep 20, 2019
Closed
@Tyriar Tyriar modified the milestones: Backlog, October 2019 Sep 20, 2019
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Sep 23, 2019
@alexdima
Copy link
Member

I've added the label bug because this manifests as a bug from the point of view of extensions which fail to work...

@Tyriar Tyriar closed this as completed in 2b61a88 Oct 25, 2019
@bpasero bpasero reopened this Oct 28, 2019
@bpasero
Copy link
Member

bpasero commented Oct 28, 2019

I reverted this as our builds are failing (integration tests):

@Tyriar Tyriar modified the milestones: October 2019, November 2019 Oct 29, 2019
@Tyriar Tyriar mentioned this issue Nov 8, 2019
Merged
@Tyriar Tyriar modified the milestones: November 2019, December 2019 Dec 2, 2019
Tyriar added a commit that referenced this issue Dec 30, 2019
@Tyriar
Revert 33cc09d
b2858ee 
Fixes #77655
@Tyriar Tyriar mentioned this issue Dec 30, 2019
Closed
@Tyriar Tyriar modified the milestones: January 2020, February 2020 Jan 27, 2020
@Tyriar Tyriar modified the milestones: February 2020, Backlog Feb 24, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Jul 7, 2021

This was fixed some time ago

@Tyriar Tyriar closed this as completed Jul 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues terminal Integrated terminal issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Revert 33cc09d microsoft/vscode
3 participants
@bpasero @Tyriar @alexdima