Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt+click in terminal resets scroll position and prevents click-on-link #78828

Closed
dwelle opened this issue Aug 9, 2019 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues verified Verification succeeded

Comments

@dwelle
Copy link

dwelle commented Aug 9, 2019

  • VSCode Version: 1.37.0 (system setup)
  • OS Version: Win 7 (Windows_NT x64 6.1.7601)

Steps to Reproduce:

  1. (optional) set "editor.multiCursorModifier": "ctrlCmd" so that links are clickable via alt
  2. open terminal → hold enter until the buffer is large enough for the terminal to be scrollable → scroll up
  3. alt+click anywhere

result: scrolls to the bottom of the terminal. If you alt+click on a link, the file doesn't open (note: if you click while the terminal is scrolled to the bottom, it works).

  • Does this issue occur when all extensions are disabled?: Yes
  • Is this fixed in insiders?: No

Terminal settings:

image

@vscodebot vscodebot bot added the new release label Aug 9, 2019
@maxshelley
Copy link

I can replicate this behaviour, VS Code Version: 1.37.0, macOS 10.14.6 (18G87).

If you alt+click on a link, the file doesn't open (note: if you click while the terminal is scrolled to the bottom, it works).

This is how I found the issue, links in my test results would only work when terminal was scrolled to the bottom.

Happy to help provide more debugging info or anything else that can be useful here.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues candidate Issue identified as probable candidate for fixing in the next release labels Aug 12, 2019
@Tyriar Tyriar added this to the July 2019 Recovery milestone Aug 12, 2019
@Tyriar
Copy link
Member

Tyriar commented Aug 13, 2019

xtermjs/xterm.js#2381

Tyriar added a commit that referenced this issue Aug 13, 2019
Diff: Tyriar/xterm.js@d20068c...e5c4432

Changes:

- Ensure selection service mousedown happens after mouse zone manager

Fixes #78828
@vscodebot vscodebot bot removed the new release label Aug 13, 2019
alexr00 pushed a commit that referenced this issue Aug 13, 2019
Diff: Tyriar/xterm.js@d20068c...e5c4432

Changes:

- Ensure selection service mousedown happens after mouse zone manager

Fixes #78828
@Tyriar Tyriar closed this as completed in fe4729e Aug 13, 2019
@roblourens roblourens added the verified Verification succeeded label Aug 14, 2019
@dwelle
Copy link
Author

dwelle commented Sep 1, 2019

While the alt+click on link has been fixed, the scroll-to-bottom still happens. This is a problem when you mis-click a link (happens a lot to me) -- it scrolls you down and you need to scroll back up to try and click again, which is a pain when working with long stack traces.

Can we maybe re-open this, or should I create a new issue?

@Tyriar
Copy link
Member

Tyriar commented Sep 6, 2019

@dwelle created #80496, xtermjs/xterm.js#2401

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 27, 2019
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Diff: xtermjs/xterm.js@f3b9dc0...95ff154

Changes:

- Fix alt click following links

Fixes microsoft#78828
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants