Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt click in terminal should not scroll down #80496

Closed
Tyriar opened this issue Sep 6, 2019 · 0 comments
Closed

Alt click in terminal should not scroll down #80496

Tyriar opened this issue Sep 6, 2019 · 0 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
September 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 6, 2019

Alt click sends sequences to move the cursor in the terminal, this should only happen when the user has not scrolled up to prevent this from happening.

Context: #78828 (comment)
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Sep 6, 2019
@Tyriar Tyriar added this to the September 2019 milestone Sep 6, 2019
@Tyriar Tyriar self-assigned this Sep 6, 2019
@Tyriar Tyriar mentioned this issue Sep 6, 2019
Closed
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 6, 2019
@Tyriar Tyriar mentioned this issue Sep 6, 2019
Closed
@Tyriar Tyriar closed this as completed in 77b3c29 Sep 6, 2019
Tyriar added a commit that referenced this issue Sep 9, 2019
@Tyriar
xterm@3.15.0-beta108
e05feff 
Brings in the fix for alt click, missed in last update

Fixes #80496
@Tyriar Tyriar added the verified Verification succeeded label Oct 2, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 21, 2019
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@3.15.0-beta107
41cc7c6 
Diff: xtermjs/xterm.js@2117005...9169108

Changes:

- Scroll bubbling
- Minor parser extensibility bugs
- Add repo field to addons
- CoreMouseService
- Bump mixin-deep and webpack deps
- Don't scroll down when alt clicking

Fixes microsoft#80496
Part of microsoft#80427
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@3.15.0-beta108
5974481 
Brings in the fix for alt click, missed in last update

Fixes microsoft#80496
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

No branches or pull requests
1 participant
@Tyriar