Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of codicons in hovers #85579

Closed
eamodio opened this issue Nov 26, 2019 · 1 comment · Fixed by #85580
Closed

Allow use of codicons in hovers #85579

eamodio opened this issue Nov 26, 2019 · 1 comment · Fixed by #85580
Assignees
@eamodio
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-hover Editor mouse hover feature-request Request for new features or functionality icons-product Issues for in-product icons
Milestone
November 2019

Comments

@eamodio
Copy link
Contributor

eamodio commented Nov 26, 2019

This would allow for a better iconography in hover (e.g GitLens):
image

Compared to Gitlens currently:
image

Related to: #84695
@eamodio eamodio added feature-request Request for new features or functionality editor-hover Editor mouse hover icons-product Issues for in-product icons labels Nov 26, 2019
@eamodio eamodio self-assigned this Nov 26, 2019
eamodio pushed a commit that referenced this issue Nov 26, 2019
Closes #85579 - adds codicons to hovers
d94edc8
This was referenced Nov 26, 2019
Merged
Closed
eamodio pushed a commit that referenced this issue Nov 26, 2019
Adds codicons to hovers (#85580)
255766f 
* Closes #85579 - adds codicons to hovers

* Uses `icon://vscode.codicons/icon-name` url structure
@eamodio eamodio added this to the November 2019 milestone Nov 26, 2019
@eamodio eamodio mentioned this issue Nov 26, 2019
Closed
devrsi0n pushed a commit to devrsi0n/vscode that referenced this issue Nov 27, 2019
Adds codicons to hovers (microsoft#85580)
92854ed 
* Closes microsoft#85579 - adds codicons to hovers

* Uses `icon://vscode.codicons/icon-name` url structure
@eamodio eamodio mentioned this issue Nov 27, 2019
Closed
@eamodio eamodio added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 3, 2019
@eamodio
Copy link
Contributor Author

eamodio commented Dec 3, 2019

Duplicate of #84695

@eamodio eamodio marked this as a duplicate of #84695 Dec 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-hover Editor mouse hover feature-request Request for new features or functionality icons-product Issues for in-product icons
Projects
None yet
Milestone
November 2019
Development

Successfully merging a pull request may close this issue.

Adds codicons to hovers microsoft/vscode
1 participant
@eamodio