Adds codicons to menu commands #85635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamodio
commented
Nov 26, 2019
| let absoluteIcon: { dark: URI; light?: URI; } | undefined; | ||
| if (icon) { | ||
| if (typeof icon === 'string') { | ||
| absoluteIcon = { dark: resources.joinPath(extension.description.extensionLocation, icon) }; | ||
| if (icon.indexOf('icon://vscode.codicons/') === 0) { | ||
| iconClassName = escape(`codicon-${URI.parse(icon).path.substr(1)}`); |
There was a problem hiding this comment.
@jrieken Not sure if I should have bothered with the URI.parse here, but wanted to keep it consistent with the other usages
jrieken
requested changes
Nov 27, 2019
| @@ -367,7 +373,8 @@ commandsExtensionPoint.setHandler(extensions => { | |||
| title, | |||
| category, | |||
| precondition: ContextKeyExpr.deserialize(enablement), | |||
| iconLocation: absoluteIcon | |||
| iconLocation: absoluteIcon, | |||
| iconClassName: iconClassName | |||
There was a problem hiding this comment.
iconClassName that shouldn't be here... I know it's not you but this stands out. We had it and spend quite some effort to get rid of this because its incompatible to Mac touch bars @misolori You seem to have added this and this is a FYI.
For this PR it means that we need to drag the URI along until it's being rendered
There was a problem hiding this comment.
iconClassName removal -> #85673
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #84695
This allows the use of codicons in menu command icons using the uri form of
icon://vscode.codicons/git-commit.//cc @jrieken
Related to: #85579 & #85624