Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup remaining svg icons #86708

Closed
14 tasks done
miguelsolorio opened this issue Dec 10, 2019 · 0 comments
Closed
14 tasks done

Cleanup remaining svg icons #86708

miguelsolorio opened this issue Dec 10, 2019 · 0 comments
Assignees
Labels
debt Code quality issues icons-product Issues for in-product icons
Milestone

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Dec 10, 2019

Since we've adopted the workbench icons to use codicons, we should cleanup these remaining ones:

  • src/vs/base/browser/ui/checkbox/checkbox.css
  • src/vs/base/browser/ui/menu/menu.css
  • src/vs/base/browser/ui/scrollbar/media/scrollbars.css
  • src/vs/editor/browser/viewParts/lineNumbers/lineNumbers.css
  • src/vs/editor/browser/widget/media/diffEditor.css
  • src/vs/editor/browser/widget/media/diffReview.css
  • src/vs/editor/contrib/parameterHints/parameterHints.css
  • src/vs/editor/standalone/browser/quickOpen/quickOutline.css
  • src/vs/workbench/browser/parts/quickopen/media/quickopen.css
  • src/vs/workbench/contrib/callHierarchy/browser/media/callHierarchy.css
  • src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.css
  • src/vs/workbench/contrib/comments/browser/media/review.css
  • src/vs/workbench/contrib/feedback/browser/media/feedback.css
  • src/vs/workbench/contrib/terminal/browser/media/terminal.css

Not referencing Codicons

  • src/vs/editor/standalone/browser/iPadShowKeyboard/iPadShowKeyboard.css
  • src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css
  • src/vs/workbench/contrib/welcome/overlay/browser/welcomeOverlay.css
  • src/vs/workbench/contrib/welcome/page/browser/welcomePage.css
  • src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.css
# Query: .svg
# Including: .css
# Excluding: extensions/*

src/vs/base/browser/ui/checkbox/checkbox.css:
  48: 	background: url('check-light.svg') center center no-repeat;
  52: 	background: url('check-dark.svg') center center no-repeat;

src/vs/base/browser/ui/menu/menu.css:
  54: 	mask: url('submenu.svg') no-repeat 90% 50%/13px 13px;
  55: 	-webkit-mask: url('submenu.svg') no-repeat 90% 50%/13px 13px;
  97: 	mask: url('check.svg') no-repeat 50% 56%/15px 15px;
  98: 	-webkit-mask: url('check.svg') no-repeat 50% 56%/15px 15px;
  210: 	mask: url('ellipsis.svg') no-repeat 50% 55%/14px 14px;
  211: 	-webkit-mask: url('ellipsis.svg') no-repeat 50% 55%/14px 14px;
  215: 	mask: url('menu.svg') no-repeat 50% 55%/16px 16px;
  216: 	-webkit-mask: url('menu.svg') no-repeat 50% 55%/16px 16px;

src/vs/base/browser/ui/scrollbar/media/scrollbars.css:
  8: 	background: url('arrow-up.svg');
  12: 	background: url('arrow-down.svg');
  16: 	background: url('arrow-left.svg');
  20: 	background: url('arrow-right.svg');
  26: 	background: url('arrow-up-dark.svg');
  30: 	background: url('arrow-down-dark.svg');
  34: 	background: url('arrow-left-dark.svg');
  38: 	background: url('arrow-right-dark.svg');

src/vs/editor/browser/viewParts/lineNumbers/lineNumbers.css:
  24: 		url('flipped-cursor.svg') 1x,
  25: 		url('flipped-cursor-2x.svg') 2x
  31: 		url('flipped-cursor-mac.svg') 1x,
  32: 		url('flipped-cursor-mac-2x.svg') 2x

src/vs/editor/browser/widget/media/diffEditor.css:
  54: 	background-image: url('addition-light.svg');
  58: 	background-image: url('deletion-light.svg');
  65: 	background-image: url('addition-dark.svg');
  71: 	background-image: url('deletion-dark.svg');
  98: 	background: url('lightbulb-light.svg') center center no-repeat;
  103: 	background: url('lightbulb-dark.svg') center center no-repeat;

src/vs/editor/browser/widget/media/diffReview.css:
  62: 	background: url('close-light.svg') center center no-repeat;
  66: 	background: url('close-dark.svg') center center no-repeat;

src/vs/editor/contrib/parameterHints/parameterHints.css:
  92: 	background-image: url('arrow-up.svg');
  96: 	background-image: url('arrow-down.svg');
  121: 	background-image: url('arrow-up-dark.svg');
  126: 	background-image: url('arrow-down-dark.svg');

src/vs/editor/standalone/browser/iPadShowKeyboard/iPadShowKeyboard.css:
  16: 	background: url('keyboard-light.svg') center center no-repeat;
  22: 	background: url('keyboard-dark.svg') center center no-repeat;

src/vs/editor/standalone/browser/quickOpen/quickOutline.css:
  12: 	background-image: url('symbol-sprite.svg');

src/vs/workbench/browser/parts/quickopen/media/quickopen.css:
  18: 	background-image: url('dirty-light.svg');
  23: 	background-image: url('dirty-dark.svg');

src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css:
  88: 	background-image: url('code-icon.svg');

src/vs/workbench/contrib/callHierarchy/browser/media/callHierarchy.css:
  24: 	background-image: url(action-call-to.svg);
  31: 	background-image: url(action-call-to-dark.svg);
  35: 	background-image: url(action-call-from.svg);
  42: 	background-image: url(action-call-from-dark.svg);

src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.css:
  55: 	background-image: url('images/chevron-previous-light.svg');
  59: 	background-image: url('images/chevron-next-light.svg');
  63: 	background-image: url('images/close-light.svg');
  68: 	background-image: url('images/chevron-previous-dark.svg');
  73: 	background-image: url('images/chevron-next-dark.svg');
  78: 	background-image: url('images/close-dark.svg');

src/vs/workbench/contrib/comments/browser/media/review.css:
  150: 	background-image: url("./close-light.svg");
  155: 	background-image: url("./close-dark.svg");
  159: 	background-image: url("./close-hc.svg");
  164: 	background-image: url("./reaction-light.svg");
  180: 	background-image: url("./reaction-dark.svg");
  184: 	background-image: url("./reaction-hc.svg");
  197: 	background-image: url("./reaction-light.svg");
  206: 	background-image: url("./reaction-dark.svg");
  210: 	background-image: url("./reaction-hc.svg");
  415: 	background: url("./close.svg") center center no-repeat;

src/vs/workbench/contrib/feedback/browser/media/feedback.css:
  123: 	background: url('close.svg') center center no-repeat;
  141: 	background-image: url('twitter.svg');
  184: 	background: url('close-dark.svg') center center no-repeat;
  188: 	background-image: url('happy.svg');
  194: 	background-image: url('sad.svg');
  200: 	background-image: url('info.svg');
  245: 	content: url('info.svg');

src/vs/workbench/contrib/terminal/browser/media/terminal.css:
  160: 	background-image: url('configure-light.svg');
  164: 	background-image: url('configure-dark.svg');
  168: 	background-image: url('configure-hc.svg');

src/vs/workbench/contrib/welcome/overlay/browser/welcomeOverlay.css:
  152: 	background-image: url('media/commandpalette.svg');
  159: 	background-image: url('media/commandpalette-dark.svg');

src/vs/workbench/contrib/welcome/page/browser/welcomePage.css:
  223: 	background-image: url('../../code-icon.svg');

src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.css:
  119: 	background-image: url('../../code-icon.svg');
@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Dec 10, 2019
@miguelsolorio miguelsolorio added this to the December/January 2020 milestone Dec 10, 2019
@miguelsolorio miguelsolorio self-assigned this Dec 10, 2019
@miguelsolorio miguelsolorio added the debt Code quality issues label Dec 12, 2019
@miguelsolorio miguelsolorio modified the milestones: March 2020, April 2020 Mar 31, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues icons-product Issues for in-product icons
Projects
None yet
Development

No branches or pull requests

1 participant