Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt codicons for bundled extensions #90911

Closed
KamasamaK opened this issue Feb 18, 2020 · 9 comments
Closed

Adopt codicons for bundled extensions #90911

KamasamaK opened this issue Feb 18, 2020 · 9 comments
Assignees
Labels
feature-request Request for new features or functionality icons-product Issues for in-product icons
Milestone

Comments

@KamasamaK
Copy link

With #84695 and related issues deployed, bundled extensions like npm and git can replace most of their bundled svg icons with native codicons.

@miguelsolorio

This comment has been minimized.

@miguelsolorio miguelsolorio added icons-product Issues for in-product icons feature-request Request for new features or functionality labels Feb 24, 2020
@miguelsolorio miguelsolorio added this to the Backlog milestone Feb 24, 2020
@jrieken

This comment has been minimized.

@miguelsolorio

This comment has been minimized.

@miguelsolorio
Copy link
Contributor

Moving the discussion from using codicons in file icons to #91973 as this issue is specific to our bundled extensions.

@KamasamaK
Copy link
Author

Looking over the two example bundled extensions, I've found a couple limitations that would prevent completely replacing with codicons.

  • For npm, the prepostscript.svg cannot be replaced because codicons do not have adjustable opacity.
  • For git, none of the status-*.svg have equivalent codicons.

@miguelsolorio
Copy link
Contributor

@KamasamaK I'm working on updating these two extensions and will address those two issue.

@KamasamaK
Copy link
Author

Just to be complete, even though I only mention those two examples there's also markdown-language-features and possibly image-preview that could use this treatment.

@miguelsolorio
Copy link
Contributor

This is already done. The markdown extension has been updated (we still need the preview icon since codicons aren't supported there) and the image preview is a webview.

@KamasamaK
Copy link
Author

Thanks. I see #99976 was opened for the Markdown extension.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality icons-product Issues for in-product icons
Projects
None yet
Development

No branches or pull requests

4 participants