Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider exposing ITerminalInstance.shellLaunchConfig as a promise #90993

Closed
Tyriar opened this issue Feb 19, 2020 · 4 comments
Closed

Consider exposing ITerminalInstance.shellLaunchConfig as a promise #90993

Tyriar opened this issue Feb 19, 2020 · 4 comments
Assignees
@Tyriar
Labels
debt Code quality issues terminal Integrated terminal issues
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 19, 2020

This could avoid problems like this #90847
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Feb 19, 2020
@Tyriar Tyriar added this to the March 2020 milestone Feb 19, 2020
@Tyriar Tyriar self-assigned this Feb 19, 2020
@dormesica
Copy link
Contributor

@Tyriar To solve #90415 I initially wanted to do something like this but it felt like a bigger change so I went with await instace.processReady.

If promise is an acceptable solution and that's OK with you, I would like to help with that.

@Tyriar
Copy link
Member Author

Tyriar commented Feb 19, 2020

@dormesica you can give it a shot, I mentioned consider as I'm not 100% sure whether we want to do this just yet or not. It does seems like what we should be doing based on what we saw with #90847 though.

@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Feb 19, 2020
@dormesica dormesica mentioned this issue Feb 23, 2020
Closed
@Tyriar Tyriar modified the milestones: March 2020, April 2020 Mar 31, 2020
@joaomoreno
Copy link
Member

@Tyriar Please remember to create scoped branches like tyriar/fix-90993 instead of #90993.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 9, 2020

@joaomoreno yep,this was a one off because I hardly ever push branches to origin from remotes and didn't rename it

@Tyriar Tyriar removed the help wanted Issues identified as good community contribution opportunities label Apr 10, 2020
@Tyriar Tyriar modified the milestones: April 2020, Backlog Apr 10, 2020
@Tyriar Tyriar closed this as completed Sep 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues terminal Integrated terminal issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

WIP #90993 - Expose shellLaunchConfig as a promise dormesica/vscode
3 participants
@joaomoreno @Tyriar @dormesica