Settings UI: Add separator for sync setting #91461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
requested changes
Feb 26, 2020
| @@ -1205,6 +1205,7 @@ export class SettingTreeRenderers { | |||
| new Separator(), | |||
| this._instantiationService.createInstance(CopySettingIdAction), | |||
| this._instantiationService.createInstance(CopySettingAsJSONAction), | |||
| new Separator(), | |||
There was a problem hiding this comment.
This shouldn't be added unless the action after it is present. Otherwise there will be a lone separator at the end of the list (at least on windows with the custom context menu)
|
I made the change so I can get this in today - thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #91395