Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not drag out sidebar when activity bar and sidebar hidden #92709

Closed
jianboy opened this issue Mar 15, 2020 · 10 comments
Closed

Can not drag out sidebar when activity bar and sidebar hidden #92709

jianboy opened this issue Mar 15, 2020 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug grid-widget Grid view widget insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues splitview-widget Splitview UI system issues verified Verification succeeded
Milestone

Comments

@jianboy
Copy link

jianboy commented Mar 15, 2020

Issue Type: Bug

zend mode is a good function. I can sliding to the right and it show side bar in vscode 1.40.

4

but it can not do it in vscode 1.43
5

VS Code version: Code 1.43.0 (78a4c91, 2020-03-09T19:47:57.235Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz (4 x 2592)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.89GB (11.89GB free)
Process Argv D:\Program Files\AutoHotkey\Script
Screen Reader no
VM 0%
Extensions (1)
Extension Author (truncated) Version
git-project-manager fel 1.7.1
@jianboy jianboy changed the title vscode can't display the side bar by sliding to the right zen mode in 1.43 it can't display the side bar by sliding to the right zen mode in vscode 1.43 Mar 15, 2020
@boltex
Copy link

boltex commented Mar 15, 2020

I would reword it as "Cannot display the side bar by dragging from the left side of the screen while in zen mode"

@isidorn isidorn changed the title it can't display the side bar by sliding to the right zen mode in vscode 1.43 Can not drag out sidebar when activity bar and sidebar hidden Mar 16, 2020
@isidorn
Copy link
Contributor

isidorn commented Mar 16, 2020

Thanks for the suggestion, I have renamed this issue.
I blieve this is an issue with the new layout, thus forwarding to @sbatten

@isidorn isidorn assigned sbatten and unassigned isidorn Mar 16, 2020
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues splitview-widget Splitview UI system issues labels Mar 16, 2020
@sbatten sbatten added this to the On Deck milestone Mar 16, 2020
@joaomoreno
Copy link
Member

@sbatten This is a consequence of our decision here: #84315 (comment)

@joaomoreno
Copy link
Member

Should fullscreen veto that?

@joaomoreno joaomoreno reopened this Apr 1, 2020
@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

I think so. The ideal user scenario allows them to do this when it is unambiguous.

@joaomoreno
Copy link
Member

you got it

@jianboy
Copy link
Author

jianboy commented Sep 10, 2020

can anybody fix the bug? It's been six months.

@jianboy
Copy link
Author

jianboy commented Sep 24, 2020

I'm sorry but the changes in this PR make no sense. It feels you just started deleting code and stopped when your issue got fixed.

Please follow the discussion in: #92709 (comment) The fix should be related to full screen mode being enabled.

Hello, @joaomoreno I hope you can compile the source yourself to experience whether the problem is solved. I debugged it on the master branch and solved it.

The bug has nothing to do with full screen,The problem will also occur when the window is normal size(master source). it can not drag out sidebar when activity bar and sidebar hidden. when the activity bar or the sidebar hidden, there is a problem with the absolute size of vscode windows

I try to find the line that caused the bug. There is a problem with the calculation of the two variables in the code, and this judgment is meaningless, so I deleted it and the problem was solved.

absoluteSize


	if (this._endSnappingEnabled === endSnappingEnabled) {	
			return;	
		}

@jianboy
Copy link
Author

jianboy commented Sep 24, 2020

7

@jianboy
Copy link
Author

jianboy commented Sep 24, 2020

8

@bpasero bpasero modified the milestones: Backlog, November 2020 Nov 3, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug grid-widget Grid view widget insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues splitview-widget Splitview UI system issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants
@joaomoreno @boltex @bpasero @isidorn @sbatten @rzhao271 @jianboy and others