Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: set classes to the <body> element #92953

Closed
bpasero opened this issue Mar 18, 2020 · 3 comments · Fixed by #97344
Closed

Themes: set classes to the <body> element #92953

bpasero opened this issue Mar 18, 2020 · 3 comments · Fixed by #97344
Assignees
@aeschli
Labels
themes Color theme issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@bpasero
Copy link
Member

bpasero commented Mar 18, 2020

Maybe there is a technical reason but I find it a bit weird that the theme service changes classes on the <body> element, especially when VSCode is running on Web in a specific container.

Do we actually need to do it this way, why can the theme service not set it on the workbench container?

image
@bpasero bpasero added themes Color theme issues under-discussion Issue is under discussion for relevance, priority, approach labels Mar 18, 2020
@bpasero
Copy link
Member Author

bpasero commented Mar 18, 2020

This applies to file icons as well it seems.

@aeschli
Copy link
Contributor

aeschli commented Mar 18, 2020

It is on the workbench container..

vscode/src/vs/workbench/services/themes/browser/workbenchThemeService.ts

Line 102 in e38fba5

this.container = layoutService.getWorkbenchContainer();

Feel free to change it...

@bpasero
Copy link
Member Author

bpasero commented Mar 19, 2020 •
edited

@aeschli it is not so easy, changing it to be the workbench element results in this flicker on startup:

Kapture 2020-03-19 at 8 59 43

I am puzzled what condition could check on body for these classes, do you have any clue?

aeschli added a commit that referenced this issue May 9, 2020
@aeschli
Themes: set classes to the <body> element. Fixes #92953
76d6127
@aeschli aeschli mentioned this issue May 9, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
themes Color theme issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Themes: do not set classes to the <body> element. microsoft/vscode
2 participants
@bpasero @aeschli