Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customize the window title separator #94254

Closed
muuvmuuv opened this issue Apr 2, 2020 · 7 comments · Fixed by #94371
Closed

Allow customize the window title separator #94254

muuvmuuv opened this issue Apr 2, 2020 · 7 comments · Fixed by #94371
Assignees
Labels
feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes titlebar VS Code main title bar issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@muuvmuuv
Copy link
Contributor

muuvmuuv commented Apr 2, 2020

The separator in window.title is a em dash but I would like to use my own "◆". Can I make a PR to add this?

@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 2, 2020
@bpasero
Copy link
Member

bpasero commented Apr 2, 2020

Why is this needed, can't you just define the full window title including your separator?

@muuvmuuv
Copy link
Contributor Author

muuvmuuv commented Apr 2, 2020

Yes but it will not make use of the "if clause" the separator variable provides. So it is only active if both variables, left and right, are present.

When I do that:

${remoteName} ◆ ${rootName} ◆ ${activeEditorMedium} ${dirty}

It results in:

◆ project ◆ package.json

Sorry I thought that would be clear. My bad.

@bpasero bpasero added feature-request Request for new features or functionality titlebar VS Code main title bar issues and removed info-needed Issue requires more information from poster labels Apr 2, 2020
@bpasero bpasero added this to the Backlog Candidates milestone Apr 2, 2020
@vscodebot
Copy link

vscodebot bot commented Apr 2, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@bpasero
Copy link
Member

bpasero commented Apr 2, 2020

Makes sense. So this could be a setting where the value of the title separator can be defined as string?

@muuvmuuv
Copy link
Contributor Author

muuvmuuv commented Apr 2, 2020

Yes, that is what I was looking for. I can make a PR if I get some time today.

I guess this is just finding where window.title is defined and add window.titleSeparator as string and place it at the line where the separator is defined?

@bpasero
Copy link
Member

bpasero commented Apr 2, 2020

Yeah if you sketch something up we can talk about it in the PR.

@bpasero bpasero modified the milestones: Backlog Candidates, On Deck Apr 6, 2020
@bpasero bpasero added the verification-needed Verification of issue is requested label Apr 7, 2020
@bpasero bpasero modified the milestones: On Deck, April 2020 Apr 7, 2020
@bpasero
Copy link
Member

bpasero commented Apr 7, 2020

Verify using the new window.titleSeparator setting.

@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 29, 2020
@bpasero bpasero added the on-release-notes Issue/pull request mentioned in release notes label May 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes titlebar VS Code main title bar issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants