Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add window title separator prop #94371

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Feature: add window title separator prop #94371

merged 1 commit into from
Apr 7, 2020

Conversation

muuvmuuv
Copy link
Contributor

@muuvmuuv muuvmuuv commented Apr 3, 2020

This PR fixes #94254

@muuvmuuv
Copy link
Contributor Author

muuvmuuv commented Apr 3, 2020

cc: @bpasero

@bpasero bpasero added this to the On Deck milestone Apr 5, 2020
bpasero
bpasero requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but it seems I can trick a new line character into the title, so this needs to be normalized somehow:

"window.titleSeparator": " <\n> "

image

@bpasero
Copy link
Member

bpasero commented Apr 7, 2020

Oh, I take it back, this already happens when configuring window.title with a newline.

@bpasero bpasero modified the milestones: On Deck, March 2020 Apr 7, 2020
@bpasero bpasero merged commit 84ed4b5 into microsoft:master Apr 7, 2020
@bpasero
Copy link
Member

bpasero commented Apr 7, 2020

Thanks 👍

@bpasero bpasero modified the milestones: March 2020, April 2020 Apr 7, 2020
@muuvmuuv muuvmuuv deleted the issue-94254 branch April 7, 2020 11:50
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero requested changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.

Allow customize the window title separator
2 participants
@muuvmuuv @bpasero