Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Reveal in Side Bar' confused by case-sensitive FileSystemProvider #95510

Closed
gjsjohnmurray opened this issue Apr 17, 2020 · 2 comments · Fixed by #95555
Closed

'Reveal in Side Bar' confused by case-sensitive FileSystemProvider #95510

gjsjohnmurray opened this issue Apr 17, 2020 · 2 comments · Fixed by #95555
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

  1. Clone https://github.com/microsoft/vscode-extension-samples.git

  2. Open fsprovider-sample folder

  3. Run the 'Launch Extension' configuration

  4. When the Extension Development Host window opens, use its Command Palette to run MemFS: Setup Workspace followed by MemFS: Create Files

  5. In Explorer expand xyz folder and its def subfolder.

  6. Doubleclick on each of these four files in sequence:
    image

  7. Working from left to right along the four tabs, use context menu on each in turn to invoke 'Reveal in Side Bar'
    image

  8. 🐛 fails to locate upper.txt in the tree. The first three work correctly.

VS Code version: Code - Insiders 1.45.0-insider (6e9a34c, 2020-04-16T05:45:56.832Z)
OS version: Windows_NT x64 10.0.18363

@gjsjohnmurray
Copy link
Contributor Author

I have seen similar problems when my case-sensitive filesystemprovider provides a tree with two sibling folders whose names only differ in their case.

@isidorn
Copy link
Contributor

isidorn commented Apr 17, 2020

@gjsjohnmurray thanks for filling this.
My guess would be that we have some assumptions about the platform we are on when we search for FileStats.
Looking at the code I see that we take the FileSystemProvide case sensitive capability into account, so not sure what is missing. Code pointer

const ignoreCase = !this.fileService.hasCapability(resource, FileSystemProviderCapabilities.PathCaseSensitive);

@gjsjohnmurray would you maybe put a breakpoint there and check what happens when you trigger a reveal.
I can also look into ti next week if you are busy. Thanks!

@isidorn isidorn added file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Apr 17, 2020
gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Apr 17, 2020
isidorn added a commit that referenced this issue Apr 20, 2020
fix #95510 'Reveal in Side Bar' confused by case-sensitive FileSystem…
@isidorn isidorn added this to the April 2020 milestone Apr 20, 2020
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Apr 20, 2020
@roblourens roblourens added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants