Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #95510 'Reveal in Side Bar' confused by case-sensitive FileSystem… #95555

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #95510

I initially considered making the fix at this line:

return resource && resource.scheme === Schemas.file ? !isLinux : true;

but didn't want to be responsible for the potential impact of doing it there.

Verify by following the repro in the original issue.

@isidorn
Copy link
Contributor

isidorn commented Apr 20, 2020

@gjsjohnmurray great fix. Please note that at resources.ts we do not have a dependency on the file system providers, since that is just a helper method, thus I do not think we could have fixed it there.
I love this approach. Thank you very much. Merging!
☀️ 🎉

@isidorn isidorn merged commit 2d37828 into microsoft:master Apr 20, 2020
@isidorn isidorn added this to the April 2020 milestone Apr 20, 2020
@gjsjohnmurray gjsjohnmurray deleted the fix-95510 branch April 20, 2020 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Reveal in Side Bar' confused by case-sensitive FileSystemProvider
2 participants