vscode 1.44 breaks "recent tasks" for tasks generated by my extension

[doudou]

• VSCode Version: 1.44.2
• OS Version: Ubuntu 19.04

Steps to Reproduce:

1. Run a task generated by my extension https://github.com/rock-core/vscode-rock
2. Try to re-run it from the "recent tasks" list
3. Nothing happens

The same task under "Show all tasks" do work.

One thing that might help understanding the issue on your side: the tasks don't show up under the provider's submenu, only in the "Show all tasks" entry. The task source field do match the provider name.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Task: Strange task name in recently used section (#93934)
• Shortcut Key For Task Shows Task List (#94654)
• Change debugging tab to be tasks tab (#38969)
• Add an option to disable the new "Faster task Quick Pick" functionality introduced in the March 2020 release (#95358)
• Ordering and naming tasks (#89448)

[alexr00]

I am not familiar with rock, can you provide a simple project I can open where there will be rock tasks?

[doudou]

Will do.

[doudou]

Same process than with #95814

Assuming an Ubuntu install, you'd need to run the script from this gist in an empty folder. It needs to install a bunch of things ruby-related.

Then, add the base/cmake folder in a VSCode instance where the Rock extension is installed.

Unfortunately there doesn't seem to be a way to disable all extensions while still letting the user re-enable some, so I can't check if the problem comes from a bad interaction between the rock extension and another.

[alexr00]

Thank you for the repro!
The problem is that you register a task provider here that says it will provide tasks of type autoproj.
Then here, you provide tasks with a different type. I will add some kind of error so that extension developers know that they shouldn't really be doing this.
I think I can also add a work around so that it does still work.

[alexr00]

There is not a good work around. I will only add the warning.

[doudou]

More than fair ... thanks for the help.

In any case, can I register the same provider object for different types ? Or do I have to create two ?

[alexr00]

Yes, you can have the same provider object for different types.

[doudou]

A suggestion: amending this documentation to explicitely link the 'type' from TaskDefinition with the type from registerTaskProvider (and vice-versa, probably)

[doudou]

Yes, you can have the same provider object for different types.

Tasks end up being duplicate (I don't see a parameter in resolveTask that would allow to discriminate which tasks it should return, and it will become rather ugly ... I've split into two providers).