Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Put Status Line Information In a Footer Tag #98376

Closed
jhomme opened this issue May 22, 2020 · 11 comments
Closed

Accessibility: Put Status Line Information In a Footer Tag #98376

jhomme opened this issue May 22, 2020 · 11 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@jhomme
Copy link

jhomme commented May 22, 2020

Issue Type: Feature Request

Doing this will automatically create a landmark that screen readers can use to easily find status information.

VS Code version: Code - Insiders 1.46.0-insider (da98a19, 2020-05-20T22:21:02.272Z)
OS version: Windows_NT x64 10.0.18362

@isidorn
Copy link
Contributor

isidorn commented May 26, 2020

Status line information is already captured by the role status. Thus your screen reader should read when you tell it to read status bar inforamtion. Though note there is an issue on the nvda side
nvaccess/nvda#11064

Can you elaborate what you mean by the "Footer Tag"

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues info-needed Issue requires more information from poster labels May 26, 2020
@jhomme
Copy link
Author

jhomme commented May 28, 2020 via email

@isidorn isidorn added under-discussion Issue is under discussion for relevance, priority, approach and removed info-needed Issue requires more information from poster labels May 29, 2020
@isidorn isidorn added this to the Backlog milestone May 29, 2020
@isidorn
Copy link
Contributor

isidorn commented May 29, 2020

Yes, but what would be gain by it.
@joanmarie does Orca handle footer tags in any special way?

@jhomme
Copy link
Author

jhomme commented May 29, 2020 via email

@isidorn isidorn modified the milestones: Backlog, June 2020 May 29, 2020
@isidorn
Copy link
Contributor

isidorn commented May 29, 2020

Assigning to June so we can experiment with this then.

@isidorn
Copy link
Contributor

isidorn commented Jun 9, 2020

Just tried changing our Status Bar Part to not be div but a footerand seems to work just fine.
Alternatives are: leave it as it is, or introduce two footers, one for left side and one for right side. Or to introduce a new elemetn between the part and the left and right which would be the footer containing them

@bpasero toughts if we change this?
@MarcoZehe thoughts on the usefullness of using a footer element for the status bar.

@bpasero
Copy link
Member

bpasero commented Jun 9, 2020

My understanding is that footer is just a div so it is probably fine. However my understanding was always that you do not have to use the semantic HTML elements and can do everything through ARIA roles and div too.

@isidorn
Copy link
Contributor

isidorn commented Jun 9, 2020

Exactly. We already set the appropriate ARIA roles, but it seems there would be additional benefits as @jhomme mentions. Though let's wait for more community feedback.
And yeah footer is just a div

@isidorn
Copy link
Contributor

isidorn commented Jun 10, 2020

After similar feedback from the accessibility channel I decided to change this.
Makes sense to make the status bar more easily dinstuigishable in the HTML structure.

@jhomme try it out with VS Code insiders in a couple of days and let us know how it goes.

@isidorn isidorn added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jun 10, 2020
@jhomme
Copy link
Author

jhomme commented Jun 10, 2020 via email

@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2020

@jhomme based on your comment adding verfied label

@isidorn isidorn added the verified Verification succeeded label Jun 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @isidorn @jhomme and others