Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsCode statusbar not properly read #11064

Open
isidorn opened this issue Apr 28, 2020 · 9 comments
Open

vsCode statusbar not properly read #11064

isidorn opened this issue Apr 28, 2020 · 9 comments

Comments

@isidorn
Copy link
Sponsor

isidorn commented Apr 28, 2020

  1. Open VS Code insiders
  2. Trigger read status bar in NVDA command

VS Code issue microsoft/vscode#96392

Comments from @joanmarie on what Orca is doing in Linux

Orca is doing an accessibility tree dive from the bottom up, looking for something with the accessible role of "status bar". I recently had to change it to sanity-check candidate status bars for the "showing" and "visible" accessibility states because VSCode has -- or at least used to have -- some offscreen element with ARIA role status and no contents. Orca was finding it first and not bothering to look any further.

@feerrenrut: Yeah, I ran into that Chrome hit-test thing myself in a different context. Orca now asks twice -- at least for the place where the issue came up.

@feerrenrut
Copy link
Contributor

I think this issue should be specific to vsCode. The browser case is a little more tricky since browsers may have their own window chrome status bar in addition to any HTML defined status bar, though I'm happy for that to be split into a separate bug. It may be that for "browser based" applications that don't have a status bar (most these days) we use appModules to opt-in to retrieving the status bar from the content.

See PR for overriding status bar with app modules: #9792

@Adriani90
Copy link
Collaborator

Cc: @josephsl, @JulienCochuyt is this a candidate for a custom status bar? Or is this not possible in web apps?

@josephsl

This comment has been minimized.

@feerrenrut feerrenrut changed the title Statusbar not properly read vsCode statusbar not properly read May 2, 2020
@feerrenrut
Copy link
Contributor

@josephsl you may have missed that this issue is about vsCode. Which we can easily have an appModule for with it's own strategy for getting the status bar. The two candidates strategies for fixing the current issue (caused by inaccurate results hit-testing in chromium) are:

  • When status bar isn't found, wait and try again.
    • Chromium needs to re-render and cache the area to get accurate hit test information.
  • As Orca does, search the accessibility tree from the bottom up, looking for something with the accessible role of "status bar".

@isidorn I have removed the following browser based steps to reproduce from the issue description to try to keep this on track. To fix this for general web apps running in any browser will require a number of different considerations. Hope you don't mind.

Removed from initial description

Alternative repro steps for a general web page:

  1. Have a web page with a role=status element
  2. Open that web page in chrome
  3. Trigger the NVDA command to read status bar -> "No status line found" is read 🐛
I'm happy for anyone to turn this into a new issue, where the comment from @josephsl is very relevant. @josephsl I'll hide your comment for now to prevent de-railing this issue.

@josephsl
Copy link
Collaborator

josephsl commented May 2, 2020

Hi,

Ah, makes more sense. In this case, I think @LeonarddeR is in the best position to take a look at this more thoroughly (I don't use VS Code at this time).

Thanks.

@isidorn
Copy link
Sponsor Author

isidorn commented May 4, 2020

@feerrenrut I do not mind. Thanks for looking into this!

@isidorn
Copy link
Sponsor Author

isidorn commented Mar 2, 2021

Friendly ping regarding this issue. Are there any updates or plans to tackle this one?

@feerrenrut
Copy link
Contributor

Sorry @isidorn we haven't been able to prioritize this yet.

@Adriani90
Copy link
Collaborator

@cary-rowen, @mltony, @LeonarddeR is this issue still existing with NvDA 2024.3 beta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants