Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltip for codelens-sample extension #118468

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fix tooltip for codelens-sample extension #118468

merged 1 commit into from
Mar 9, 2021

Conversation

spetrescu
Copy link
Contributor

@spetrescu spetrescu commented Mar 8, 2021 •
edited
Loading

Description

Tooltip not showing when hovering over codelens for codelens-sample extension. Thus, title attribute is used on dom-nodes to display tooltip.

Fixes #115732

Before fix

Windows & MacOS

After fix

Windows MacOS

Type of change

  • Bug fix

How Has This Been Tested?

  • unit
  • integration
  • smoke
  • ui

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@jrieken jrieken added this to the March 2021 milestone Mar 9, 2021
@jrieken
Copy link
Member

jrieken commented Mar 9, 2021

Thanks

@jrieken jrieken merged commit 6b76fcb into microsoft:main Mar 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March 2021
Development

Successfully merging this pull request may close these issues.

Tooltip not show when hover codelens
2 participants
@spetrescu @jrieken