Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an indicator for the current window #13113

Merged
merged 2 commits into from Oct 3, 2016

Conversation

heycalmdown
Copy link
Contributor

for #12997

@msftclas
Copy link

msftclas commented Oct 1, 2016

Hi @heycalmdown, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.233% when pulling bcfc586 on heycalmdown:current-indicator into 602155b on Microsoft:master.

@bpasero
Copy link
Member

bpasero commented Oct 3, 2016

@heycalmdown thanks for the PR, can we maybe try to play with the description property instead? Here is how it works code wise:

return <IPickOpenEntry>{
    label: w.title,
    description: (id === w.id) ? nls.localize('current', "Current Window") : void 0,
    run: () => {
        ipc.send('vscode:showWindow', w.id);
    }
};

and here is how it would look like:

screen shot 2016-10-03 at 09 46 25

@bpasero bpasero self-assigned this Oct 3, 2016
@heycalmdown
Copy link
Contributor Author

Clearer. Thanks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.233% when pulling e8c8407 on heycalmdown:current-indicator into 602155b on Microsoft:master.

@bpasero bpasero merged commit 1ca9b45 into microsoft:master Oct 3, 2016
@bpasero bpasero modified the milestone: October 2016 Oct 28, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants