-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimap - highlight all instances of selected word #132584
Conversation
@@ -1050,6 +1050,10 @@ export class SelectionHighlighter extends Disposable implements IEditorContribut | |||
description: 'selection-highlight-overview', | |||
stickiness: TrackedRangeStickiness.NeverGrowsWhenTypingAtEdges, | |||
className: 'selectionHighlight', | |||
minimap: { | |||
color: themeColorFromId(minimapFindMatch), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we create a new color e.g. minimalSelectionHighlight
and not reuse minimapFindMatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it a bit confusing to reuse the minimapFindMatch
color for selection highlights. I suggest to define a new color.
The color used is the same as in Atom |
… they are also rendered in the overview ruler
… rendering certain decorations in the minimap
This PR fixes #84151
Adds minimap decoration options that are the same as find decoration ones on double click selection.
To test, simply double click a word after which you will see it selected in the minimap.