make sure terminal location is defined #139019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 13, 2021
Tyriar
approved these changes
Dec 13, 2021
src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts
Show resolved
Hide resolved
Tyriar
added a commit
that referenced
this pull request
Dec 13, 2021
deepak1556
added a commit
that referenced
this pull request
Dec 14, 2021
deepak1556
added a commit
that referenced
this pull request
Dec 14, 2021
* Revert "re-enable smoke tests, keep editor fix (#139012) (#139019)" This reverts commit c4738fe. * Revert "Add yarn file (#139035)" This reverts commit b3d3156. * Revert "Bump distro and version for 1.63.1 (#139034)" This reverts commit bc22b67. * Revert "Pick up TS recovery (#138795)" This reverts commit 223411f. * Revert "Merge pull request #139017 from microsoft/sandy081/fix139013" This reverts commit e7a2ed3, reversing changes made to 7db1a2b.
meganrogge
added a commit
that referenced
this pull request
Dec 14, 2021
meganrogge
added a commit
that referenced
this pull request
Dec 14, 2021
meganrogge
added a commit
that referenced
this pull request
Dec 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #138889
fixes #138601
fixes #138770
fixes #138603