Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suggest): only show readmore icon in focused label #139792

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

OPY-bbt
Copy link
Contributor

@OPY-bbt OPY-bbt commented Dec 27, 2021

This PR fixes #139790

because of this https://github.com/microsoft/vscode/blob/main/src/vs/editor/contrib/suggest/suggestWidget.ts#L665,
the suggest details only show content related to focused label.
this PR hidden readmore icon in unfocused labels.

thanks

@OPY-bbt OPY-bbt changed the title fix(suggest): only show readmore icon in focused item fix(suggest): only show readmore icon at focused label Dec 27, 2021
@OPY-bbt OPY-bbt changed the title fix(suggest): only show readmore icon at focused label fix(suggest): only show readmore icon in focused label Dec 27, 2021
@rzhao271 rzhao271 assigned jrieken and unassigned rzhao271 Dec 27, 2021
@jrieken jrieken added this to the January 2022 milestone Jan 3, 2022
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks

@jrieken jrieken merged commit 26eb8ea into microsoft:main Jan 3, 2022
@OPY-bbt OPY-bbt deleted the fix-suggest-detail branch January 6, 2022 02:15
@github-actions GitHub Actions bot locked and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggest detail show error content
3 participants