update to latest seti-ui version #141931
Merged
update to latest seti-ui version #141931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
miguelsolorio
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Not sure if you ran npm run update from the instructions, but had to manually run that and it looks good:
Thanks for the PR!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In respect to the CONTRIBUTING.md these PR updates the seti-ui icon theme.
It handles .avif files as images (see jesseweed/seti-ui#639)
AVIF is a somewhat newer and open image format from 2019. It is well supported by vscode, Chrome, Firefox, Windows, Android, most Linux distros and so on (see Wikipedia). It is a good candidate for being a successor of jpeg, png and webp also with regard to the licence. A comparsion with other image file format is also available at Mozilla Dev.
Here is the screenshot of the
preview.html