Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes remote extension fails to activate in web worker extension host #144515

Closed
wants to merge 1 commit into from

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Mar 6, 2022

This PR fixes #144513

This fixes the issue by fetching the extension entry point URI in the main thread.
In the case of codespaces, the request will be intercepted by a service worker in the main thread.
In gitpod case, some authentication cookies available in the main thread were required.

@alexdima
Copy link
Member

Thank you, this would work, but I've decided to do a server-side fix via 448ada0

@alexdima alexdima closed this Mar 24, 2022
@jeanp413 jeanp413 deleted the fix-144513 branch March 26, 2022 03:26
@jeanp413 jeanp413 restored the fix-144513 branch April 29, 2022 12:25
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote extension fails to activate in web worker extension host
3 participants