145458 List: Support scroll by page #145788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Qasem-h
previously approved these changes
Mar 23, 2022
joaomoreno
approved these changes
Jan 2, 2023
|
Sorry for the delay reviewing this. Pushed minor changes as a lot of the code wasn't really necessary. Waiting for a second approval to merge this. Many thanks and great work! 🍻 |
|
Thank you for the review :D |
lszomoru
approved these changes
Jan 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option scrollByPage is now available for list, to enable the feature on every scrollbar.
This PR fixes #145458
(I ended up copy-pasting more code than I initially expected, please let me know if there's something to remove or everything is needed to cover all cases)