Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor scrolling behavior after notebook model reset #150306

Merged
merged 5 commits into from
Jun 6, 2022
Merged

Poor scrolling behavior after notebook model reset #150306

merged 5 commits into from
Jun 6, 2022

Conversation

roblourens
Copy link
Member

For #148164

  1. Kick off markdown rendering in background after markdown cells are added
  2. Fix issue with cell editor trying to reveal itself when it gets rendered
  3. Fix cell being resized after it is disposed, causing some issues

@roblourens roblourens requested a review from rebornix May 24, 2022 19:33
@VSCodeTriageBot VSCodeTriageBot added this to the May 2022 milestone May 24, 2022
@roblourens
Update scroll dimensions before scrolltop, otherwise the scrollTop wi…
35c61b2 
…ll be clamped when a cell above the viewport got larger
rebornix
rebornix previously approved these changes May 24, 2022
View reviewed changes
src/vs/base/browser/ui/list/listView.ts Outdated Show resolved Hide resolved
rebornix
rebornix previously approved these changes May 25, 2022
View reviewed changes
@roblourens
Revert "Update scroll dimensions before scrolltop, otherwise the scro…
6071a91 
…llTop will be clamped when a cell above the viewport got larger"

This reverts commit 35c61b2.
alexdima
alexdima previously approved these changes May 30, 2022
View reviewed changes
@roblourens roblourens modified the milestones: May 2022, June 2022 May 31, 2022
@roblourens roblourens enabled auto-merge (squash) June 6, 2022 23:30
@roblourens roblourens merged commit 05d23f1 into main Jun 6, 2022
@roblourens roblourens deleted the roblourens/issue148164_3 branch June 6, 2022 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lramos15 lramos15 lramos15 approved these changes

@rebornix rebornix rebornix left review comments

@alexdima alexdima alexdima left review comments

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@roblourens @rebornix @lramos15 @alexdima @VSCodeTriageBot