add aria-description support for selectbox #152251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,6 +126,10 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi | |||
| this.selectElement.setAttribute('aria-label', this.selectBoxOptions.ariaLabel); | |||
| } | |||
|
|
|||
| if (this.selectBoxOptions.ariaDescription) { | |||
There was a problem hiding this comment.
Probably best to keep the check similar to the other ones
typeof this.selectBoxOptions.ariaDescription === 'string'
| @@ -35,6 +35,10 @@ export class SelectBoxNative extends Disposable implements ISelectBoxDelegate { | |||
| this.selectElement.setAttribute('aria-label', this.selectBoxOptions.ariaLabel); | |||
| } | |||
|
|
|||
| if (this.selectBoxOptions.ariaDescription) { | |||
There was a problem hiding this comment.
Same here - typeof this.selectBoxOptions.ariaDescription === 'string'
|
@alanrenmsft thanks for the PR. I think this makes sense, even though aria-description is not yet supported by all screen readers to my knowledge. |
isidorn
approved these changes
Jun 16, 2022
justschen
pushed a commit
to justschen/vscode
that referenced
this pull request
Jun 16, 2022
add aria-description support for selectbox
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while working on an accessibility issue for Azure Data Studio (a fork of vscode), we realized that this option is missing, thought it could be useful for VSCode too, so created this PR.