Fix KaTeX equation numbering in notebook preview #156276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155888
Explanation
the KaTex has a stylesheet
https://github.com/KaTeX/KaTeX/blob/9164a15ef817161aa8f33beb0688e660fff87dd2/src/katex.less#L677
which will compile into
vscode/extensions/markdown-math/notebook-out/katex.min.css
However, the
body
style is not effective inside shadow-root element and will cause #155888.Adding this styles to shadow root explicitly will fix the issue.
Before:
![CleanShot 2022-07-26 at 17 53 02](https://user-images.githubusercontent.com/5123601/180982389-abde51c2-3179-4b2e-89b9-b41c5815fd23.png)
After:
![CleanShot 2022-07-26 at 17 58 35](https://user-images.githubusercontent.com/5123601/180982405-cf9cdf19-8581-4b34-bfdd-561a2a244de1.png)