Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit editor inactive selection colors in terminal (Fix #158899) #158950

Merged
merged 6 commits into from Aug 24, 2022
Merged

Inherit editor inactive selection colors in terminal (Fix #158899) #158950

merged 6 commits into from Aug 24, 2022

Conversation

daviddossett
Copy link
Contributor

@daviddossett daviddossett commented Aug 23, 2022 •
edited

Fix #158899

@VSCodeTriageBot VSCodeTriageBot added this to the August 2022 milestone Aug 23, 2022
Tyriar
Tyriar requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this was intentional, consider if existing themes set both editor and terminal to different colors, an editor inactive selection derived color will look out of place. For the off cases like this we should define terminal inactive selection in those themes

@daviddossett
Copy link
Contributor Author

Oh this was intentional, consider if existing themes set both editor and terminal to different colors, an editor inactive selection derived color will look out of place. For the off cases like this we should define terminal inactive selection in those themes

Yep ok I see what's happening now, thanks. Updated.

Tyriar
Tyriar previously approved these changes Aug 24, 2022
View reviewed changes
extensions/theme-monokai/themes/monokai-color-theme.json Outdated Show resolved Hide resolved
@daviddossett daviddossett enabled auto-merge (squash) August 24, 2022 22:53
@daviddossett daviddossett merged commit 52f8bfa into main Aug 24, 2022
@daviddossett daviddossett deleted the ddossett/thoughtful-butterfly branch August 24, 2022 23:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@daviddossett daviddossett

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

Should the default inactive terminal selection background be the same one as used by the editor
3 participants
@daviddossett @Tyriar @VSCodeTriageBot