Command Center With Help #163635
Merged
Command Center With Help #163635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmarti
approved these changes
Oct 14, 2022
bpasero
reviewed
Nov 8, 2022
| }); | ||
| } | ||
| } | ||
| public getQuickAccessProviders(): IHelpQuickAccessPickItem[] { |
There was a problem hiding this comment.
@TylerLeonhardt personal taste is to not use public but have it removed
bpasero
reviewed
Nov 8, 2022
| // do not rewrite value from user typing! | ||
| preserveValue: true, | ||
| // persist the value of the providerOptions from the original showing | ||
| providerOptions: providerOptions |
There was a problem hiding this comment.
@TylerLeonhardt easier as just providerOptions
bpasero
reviewed
Nov 8, 2022
| @@ -52,6 +52,10 @@ import { withNullAsUndefined } from 'vs/base/common/types'; | |||
| import { Codicon } from 'vs/base/common/codicons'; | |||
| import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; | |||
| import { stripIcons } from 'vs/base/common/iconLabels'; | |||
| import { HelpQuickAccessProvider } from 'vs/platform/quickinput/browser/helpQuickAccess'; | |||
| import { CommandsQuickAccessProvider } from 'vs/workbench/contrib/quickaccess/browser/commandsQuickAccess'; | |||
| import { DEBUG_QUICK_ACCESS_PREFIX } from 'vs/workbench/contrib/debug/browser/debugCommands'; | |||
There was a problem hiding this comment.
@TylerLeonhardt not super happy with a dependency of search to debug and task component only to get this working. Would be great if this can be done only by depending on the help provider.
|
👏 , lets sync today on this change for some feedback I have. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158638
Now when you launch the command center you get:
Additionally, if you go into a provider (say
>) and then backspace out of it, thus returning toGo to file...you still get the Help.To be clear, this only shows when you click on the command center. Cmd+P is not impacted at all.
we can improve on this later with pills and whatnot, but this gives the command center a bit more utility than just launching Cmd+P.
cc @daviddossett
gonna cc @bpasero for a late review when you're back from being OOF