Remove the 馃 since we have modes in the go to file #164437
Conversation
| } | ||
| // If the command center is visible then the quickinput should go over the title bar and the banner | ||
| if (this.titleService.isCommandCenterVisible) { | ||
| quickPickTop = 0; |
There was a problem hiding this comment.
Unrelated change? Will also overlay the banner which I believe is unwanted?
There was a problem hiding this comment.
@jrieken I actually wanted that. because otherwise the command center disappears and it looks weird.
There was a problem hiding this comment.
makes sense to my but maybe /cc @daviddossett given emotion with the banner were high. I agree for better looks but I believe the point of the banner is to not be permanent?
There was a problem hiding this comment.
Not sure I follow鈥攚hat is the effect of this?
There was a problem hiding this comment.
@daviddossett so you know we have this banner:
today, if you have that banner (be in an untrusted workspace) and you launch the command center this happens:
Actually I think that's a bug because really what the code was intending to do, originally, was have the quick pick be under the banner so it didn't cover it basically with the idea that "overlaying anything over the banner is bad"...
My change says "covering the banner for the quick pick is ok" and has the quick pick do what it does today in an untrusted workspace.
There was a problem hiding this comment.
I think covering it is totally ok personally. It would be strange to decouple the command center button/input from the quick pick itself.
I don't actually see the titlebar element in the second screenshot. Is that intentional?
There was a problem hiding this comment.
Yeah it is hidden when you click on it since it is often longer than the quickpick itself.
There was a problem hiding this comment.
Ok, got it. In any case I think quick picks should always take priority given their z-index and not be considered part of the normal flow of elements. In other words, they should always be positioned at the very top of the window IMO.
There was a problem hiding this comment.
I think we're all in agreement. I'll defer to @jrieken for a re-review
Fixes #163957