Register theme participant refactoring #165576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
approved these changes
Nov 14, 2022
I think the default color will be transparent and the typescript check is just an optimization. We'll see if it works in tomorrows insider ;) |
|
@hediet Awesome! Are there any other tasks from this issue I could pick up? |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #165169
src/vs/workbench/contrib/codeEditor/browser/accessibility/accessibility.tssrc/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.tssrc/vs/workbench/contrib/codeEditor/browser/inspectEditorTokens/inspectEditorTokens.tssrc/vs/workbench/contrib/codeEditor/browser/untitledTextEditorHint.ts[1]src/vs/workbench/contrib/codeEditor/browser/suggestEnabledInput/suggestEnabledInput.ts[2][1] - Needed to add a CSS file and move the .ts and .css file into a separate folder
[2] - Seems like this file uses some conditional logic, I'm not sure if we can move it completely to CSS variables. If there's anything I can do though in this one, let me know.
Also, I had a query. Most of the ones we are replacing have a condition in the TypeScript file that checks if that variable has a value, then it adds the CSS rule. I don't think this condition would be checked while using CSS Variables right.
So, do the variables always have some default value, or will there be a case when the variable might be undefined and cause an issue?