Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrow nav on dropdown action buttons focusing hidden dropdown #167662

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

Charles-Gagnon
Copy link
Contributor

Fixes #164050

TabFix

@mjbvz mjbvz assigned sandy081 and unassigned mjbvz Nov 30, 2022
@sandy081 sandy081 added this to the December 2022 milestone Nov 30, 2022
@roblourens roblourens added the deferred Issues that were automatically moved out of the release milestone label Jan 27, 2023
@sandy081 sandy081 modified the milestones: February 2023, Backlog Feb 22, 2023
@Charles-Gagnon
Copy link
Contributor Author

@sandy081 Any chance you'd have time to look at this? This is still an issue in the latest 1.78.2 version of VS Code

@sandy081
Copy link
Member

Will check next milestone

@sandy081 sandy081 modified the milestones: Backlog, June 2023 May 30, 2023
@sandy081 sandy081 removed triage-needed deferred Issues that were automatically moved out of the release milestone labels May 30, 2023
@sandy081 sandy081 modified the milestones: June 2023, July 2023 Jun 27, 2023
@andreamah andreamah modified the milestones: July 2023, August 2023 Jul 26, 2023
@sandy081 sandy081 modified the milestones: August 2023, September 2023 Jul 27, 2023
@sandy081 sandy081 self-requested a review September 26, 2023 09:43
@sandy081 sandy081 modified the milestones: September 2023, Backlog Sep 26, 2023
@sandy081 sandy081 modified the milestones: Backlog, October 2023 Oct 9, 2023
@sandy081 sandy081 merged commit e1ee079 into microsoft:main Oct 9, 2023
6 checks passed
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/fixActionButtonTab branch October 9, 2023 15:15
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
…ctionButtonTab

Fix arrow nav on dropdown action buttons focusing hidden dropdown
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing right arrow when selecting an action button with no menu actions selects hidden div
7 participants