Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to search in notebook inputs (under experimental flag) #167952

Merged
merged 39 commits into from
Feb 13, 2023
Merged

Add ability to search in notebook inputs (under experimental flag) #167952

merged 39 commits into from
Feb 13, 2023

Commits on Nov 7, 2022

  1. initial marks

    @andreamah
    andreamah committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f895929 View commit details
    Browse the repository at this point in the history

  2. initial changes to support notebook editor binding

    @andreamah
    andreamah committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    03ad467 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. change notebook track qualifications

    @andreamah
    andreamah committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    cc1a778 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. needs to read into dom

    @andreamah
    andreamah committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6bba961 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. random logs

    @andreamah
    andreamah committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    75dddd2 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. some progress on notebook search

    @andreamah
    andreamah committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    b7f40ea View commit details
    Browse the repository at this point in the history

  2. Improve workspace text search with notebook editors 

    Fixes #148068
    @andreamah
    andreamah committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    ac5a174 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. some rendered content showing in search viewlet

    @andreamah
    andreamah committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    90763cc View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. rough draft of notebook search

    @andreamah
    andreamah committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    e37722e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. move local notebook search out of searchservice

    @andreamah
    andreamah committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    d20ea1d View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. working replace

    @andreamah
    andreamah committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    188ee99 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. add propert highlighting and open notebook editor when replace active

    @andreamah
    andreamah committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    51c667e View commit details
    Browse the repository at this point in the history

  2. merge main

    @andreamah
    andreamah committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    65337b5 View commit details
    Browse the repository at this point in the history

  3. cleanup and compile error fixing

    @andreamah
    andreamah committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    da22b6a View commit details
    Browse the repository at this point in the history

  4. fix function for notebook opening in search

    @andreamah
    andreamah committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    779e721 View commit details
    Browse the repository at this point in the history

  5. clarity on shouldOpenInNotebookEditor

    @andreamah
    andreamah committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    b8c5133 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. added experimental flag

    @andreamah
    andreamah committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    15ea8bc View commit details
    Browse the repository at this point in the history

  2. extra docs for notebook extractSelectionLine

    @andreamah
    andreamah committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    310c13a View commit details
    Browse the repository at this point in the history

  3. fix experimental flag bug

    @andreamah
    andreamah committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    a782747 View commit details
    Browse the repository at this point in the history

  4. resolve merge

    @andreamah
    andreamah committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    f262935 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. incorporated shared findMatchDecorationModel

    @andreamah
    andreamah committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    eff7d26 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. jump to nth result on raw text results to notebook results

    @andreamah
    andreamah committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b1e69a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Merge branch 'main' into andreamah/issue148068

    @andreamah
    andreamah committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    136438c View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. fix bug with focus shift

    @andreamah
    andreamah committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    7b97332 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @andreamah
    andreamah committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    349b100 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. fix tests and cleanup

    @andreamah
    andreamah committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    d11d169 View commit details
    Browse the repository at this point in the history

  2. extra cleanup for match decorations

    @andreamah
    andreamah committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    4cd6107 View commit details
    Browse the repository at this point in the history

  3. cleanup diffs

    @andreamah
    andreamah committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    5409745 View commit details
    Browse the repository at this point in the history

  4. remove comments and add readonly field

    @andreamah
    andreamah committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    a368db1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. remove webview extract match for now

    @andreamah
    andreamah committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    917ac78 View commit details
    Browse the repository at this point in the history

  2. remove comma

    @andreamah
    andreamah committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    aa79ffc View commit details
    Browse the repository at this point in the history

  3. use onDidAddNotebookEditor

    @andreamah
    andreamah committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    99c2baa View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. add simple tests

    @andreamah
    andreamah committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3cbc5af View commit details
    Browse the repository at this point in the history

  2. test corrections

    @andreamah
    andreamah committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b4c213e View commit details
    Browse the repository at this point in the history

  3. move notebooksearchhelper tests

    @andreamah
    andreamah committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2bfad50 View commit details
    Browse the repository at this point in the history

  4. PR feedback

    @andreamah
    andreamah committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9d16b92 View commit details
    Browse the repository at this point in the history

  5. add listener dispose

    @andreamah
    andreamah committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    8255fc5 View commit details
    Browse the repository at this point in the history

  6. get notebook model for replace using notebookEditorModelResolverService

    @andreamah
    andreamah committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    350ed49 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. dispose reference to notebook in replaceService

    @andreamah
    andreamah committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    3c94737 View commit details
    Browse the repository at this point in the history