Unfreeze Git grammars #168698
Closed
Unfreeze Git grammars #168698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, editing the Git grammars required making PRs to https://github.com/textmate/git.tmbundle and then importing the new grammars in here. However, that upstream repo is dead: * No changes since 2019: https://github.com/textmate/git.tmbundle/commits/master * Upstream test suite requires ruby 1.8.7, which is EOL since 2014: textmate/git.tmbundle#59 With this change in place, it is now possible to make PRs to improve Git grammars, to solve problems like this one for example: microsoft#133888
This comment was marked as outdated.
This comment was marked as outdated.
|
@microsoft-github-policy-service agree |
|
Adding @alexr00 as she manages the grammars that are included in VS Code. |
|
@walles thank you for the PR. We on the VS Code team are not grammar experts, so we depend on other OSS projects to get our syntax highlighting grammars. Rather than allowing changes to the git grammar in this repo, I would prefer to find a different OSS project to depend on for our git grammars. We've done this several times in the last couple years (C++ and Razor come to mind) and I'd be happy to do the same for git if we can find an OSS project with a good track record. |
|
Take two: #173195 Now with a new upstream project with a runnable + passing test suite. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, editing the Git grammars required making PRs to https://github.com/textmate/git.tmbundle and then importing the new grammars in here.
However, that upstream repo is dead:
Specs require Ruby version that's EOL since 2014 textmate/git.tmbundle#59
With this change in place, it is now possible to make PRs to improve Git grammars, to solve problems like this one for example: #133888