💬 Add PID and executable/arguments to terminal tab hover #171258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
|
@Tyriar Sorry, I just pushed a commit to escape possible markdown tokens in the arguments list. |
hediet
previously approved these changes
Jan 13, 2023
Tyriar
reviewed
Feb 7, 2023
It was causing bad wrapping and a really wide hover
connor4312
previously approved these changes
Mar 15, 2023
Tyriar
approved these changes
Mar 16, 2023
chrmarti
approved these changes
Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170580
I think this can be a good starter. It adds the PID and executable/arguments to terminal tab hovers.
Note that, I took the quoting of the arguments from here. However, I'm not sure if it works with all special cases (e.g., those having a single quote character within the arg values).
Here are some screen captures of the updated hovers:
(Tabbed, without arguments)
(Tabbed, with arguments)
(Single tab, without arguments)
