Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search for output rich content in notebooks #173978

Merged
merged 53 commits into from
Mar 17, 2023
Merged

Add search for output rich content in notebooks #173978

merged 53 commits into from
Mar 17, 2023

Conversation

andreamah
Copy link
Contributor

Fixes #164926

@andreamah
initial marks
f895929
@andreamah
initial changes to support notebook editor binding
03ad467
@andreamah
change notebook track qualifications
cc1a778
@andreamah
needs to read into dom
6bba961
@andreamah
random logs
75dddd2
@andreamah
some progress on notebook search
b7f40ea
@andreamah
Improve workspace text search with notebook editors
ac5a174 
Fixes #148068
@andreamah
some rendered content showing in search viewlet
90763cc
@andreamah
rough draft of notebook search
e37722e
@andreamah
move local notebook search out of searchservice
d20ea1d
@andreamah
working replace
188ee99
@andreamah
add propert highlighting and open notebook editor when replace active
51c667e
@andreamah
merge main
65337b5
@andreamah
cleanup and compile error fixing
da22b6a
@andreamah
fix function for notebook opening in search
779e721
@andreamah
clarity on shouldOpenInNotebookEditor
b8c5133
@andreamah
added experimental flag
15ea8bc
@andreamah
extra docs for notebook extractSelectionLine
310c13a
@andreamah
fix experimental flag bug
a782747
@andreamah
resolve merge
f262935
@andreamah
incorporated shared findMatchDecorationModel
eff7d26
@andreamah
jump to nth result on raw text results to notebook results
b1e69a1
@andreamah
Merge branch 'main' into andreamah/issue148068
136438c
@andreamah
fix bug with focus shift
7b97332
@andreamah
cleanup
349b100
@andreamah
fix tests and cleanup
d11d169
@andreamah
extra cleanup for match decorations
4cd6107
@andreamah
cleanup diffs
5409745
@andreamah
remove comments and add readonly field
a368db1
@andreamah
remove webview extract match for now
917ac78
@andreamah andreamah changed the title Add search for output rich content Add search for output rich content in notebooks Mar 8, 2023
@andreamah andreamah marked this pull request as ready for review March 8, 2023 22:18
@VSCodeTriageBot VSCodeTriageBot added this to the March 2023 milestone Mar 8, 2023
roblourens
roblourens reviewed Mar 10, 2023
View reviewed changes
src/vs/workbench/contrib/search/browser/searchWidget.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/search/browser/searchWidget.ts Outdated Show resolved Hide resolved
src/vs/workbench/services/search/common/search.ts Outdated
}

export interface INotebookPatternInfo {
isNotebookMarkdownInput?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the names, is it like isNotebookMarkdownInputEnabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the naming, but yes, it's whether we search the notebook's cell source on markdown cells.

rebornix
rebornix reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the idea of reusing the view for NotebookFindFilter. Now we can move the visibility control out of NotebookFindWidget and have it only in the SearchInput.

src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.css Outdated Show resolved Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts Show resolved Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts Outdated Show resolved Hide resolved
rebornix
rebornix previously approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreamah thank you for making the change in notebook land minimal. Great work!

@andreamah andreamah merged commit 2c8cfa7 into main Mar 17, 2023
@andreamah andreamah deleted the andreamah/notebook-rich-content-output branch March 17, 2023 18:29
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

@rebornix rebornix rebornix approved these changes

Assignees

@andreamah andreamah

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

Create options for performing global search that includes rendered and outputted notebook content
4 participants
@andreamah @roblourens @rebornix @VSCodeTriageBot