Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking service worker path for non-ascii chars #177716

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Mar 20, 2023

Fixes #166860

@mjbvz mjbvz added this to the March 2023 milestone Mar 20, 2023
@mjbvz mjbvz self-assigned this Mar 20, 2023
@mjbvz mjbvz enabled auto-merge (squash) March 20, 2023 21:11
@@ -259,6 +259,8 @@
// service worker already loaded & ready to receive messages
postVersionMessage(currentController);
} else {
console.log(`Found unexpected service worker controller. Found: ${currentController?.scriptURL}. Expected: ${swPath}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this console.log still be here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these were added to help us understand if a user is in this case which could be a sign of issues

@mjbvz mjbvz merged commit 40ac8e9 into microsoft:main Mar 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An UI(maybe) bug causing .ipynb files can not be displayed
2 participants