Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote: first cut at 'inline' remote resolvers #180263

Merged
merged 20 commits into from
May 15, 2023

Commits on Apr 18, 2023

  1. remote: first cut at 'inline' remote resolvers

    For web, it seems the most feasible direction for resolvers as we make
    existing remote extensions 'web enabled' is to allow them to run in the
    extension host. However, in no case will there just be a simple
    websocket we can connect to ordinarily.
    
    This PR implements a first cut at 'inline' resolvers where messaging is
    done in the extension host. I have not yet tested them on web, where I
    think some more wiring is needed to mirror desktop. Also, resolution of
    URLs is not in yet. I think for this we'd want to do some service-worker
    -based 'loopback' approach to run requests inline in the remote
    connection, similar to what I did for tunnels...
    
    Resolvers are not yet run in a dedicated extension host, but I think
    that should happen, at least on web where resolvers
    will always(?) be 'inline'.
    
    Most of the actual changes are genericizing places where we specified
    the "host" and "port" previously into an enum. Additionally, instead of
    having a single ISocketFactory, there's now a collection of them, which
    the extension host manager registers into when a managed resolution
    happens.
    connor4312 committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f5427ee View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Configuration menu
    Copy the full SHA
    ddfcf37 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2023

  1. Renames

    alexdima committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    df8de50 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6cf3664 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Get rid of IConnectCallback

    alexdima committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    1aa5477 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    5bb593e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bc8da8 View commit details
    Browse the repository at this point in the history
  3. address pr comment

    connor4312 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    e71c429 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. 💄 reduce diff

    alexdima committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6dcaf9a View commit details
    Browse the repository at this point in the history
  2. 💄 reduce diff

    alexdima committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0029cab View commit details
    Browse the repository at this point in the history
  3. 💄 improve logging, make sure to continue throwing if the remote autho…

    …rity doesn't contain a '+' and is not in a 'hostname:port' format
    alexdima committed May 10, 2023
    Configuration menu
    Copy the full SHA
    1439f53 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Add dedicated protocol for managed sockets (mainThreadManagedSockets …

    …and extHostManagedSockets)
    alexdima committed May 11, 2023
    Configuration menu
    Copy the full SHA
    dde5a4f View commit details
    Browse the repository at this point in the history
  2. Delete only on close

    alexdima committed May 11, 2023
    Configuration menu
    Copy the full SHA
    12b39c3 View commit details
    Browse the repository at this point in the history
  3. 💄 reduce diff

    alexdima committed May 11, 2023
    Configuration menu
    Copy the full SHA
    273b73d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    66f719f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    364b84e View commit details
    Browse the repository at this point in the history
  6. address pr comments

    connor4312 committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f76fd4f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Fix wrong used symbol

    alexdima committed May 12, 2023
    Configuration menu
    Copy the full SHA
    cf93b3f View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/connor4312/inline-remote-resolve…

    …r' into connor4312/inline-remote-resolver
    connor4312 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d28b8fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    482c4bf View commit details
    Browse the repository at this point in the history