Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a nonce to verify si commands #181523

Merged
merged 5 commits into from May 4, 2023
Merged

Use a nonce to verify si commands #181523

merged 5 commits into from May 4, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 4, 2023 •
edited

Fixes #181522

Remaining:

  • Provide both trusted and untrusted values internally
  • Test pwsh
  • Test bash
  • Test zsh
  • Test fish
  • Notify nu they use the 133 sequence and don't send 633 E currently
  • Notify julia

@Tyriar Tyriar added this to the May 2023 milestone May 4, 2023
@Tyriar Tyriar self-assigned this May 4, 2023
@Tyriar Tyriar mentioned this pull request May 4, 2023
Open
@Tyriar Tyriar requested a review from meganrogge May 4, 2023 16:24
@Tyriar Tyriar marked this pull request as ready for review May 4, 2023 16:24
@Tyriar Tyriar merged commit 43b07bf into main May 4, 2023
7 checks passed
@Tyriar Tyriar deleted the tyriar/181522 branch May 4, 2023 16:35
@Tyriar Tyriar mentioned this pull request May 11, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

Use a nonce to verify shell integration command lines
2 participants
@Tyriar @meganrogge