-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for workspaceState
sync
#182234
Fixes for workspaceState
sync
#182234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once workspace state becomes part of settings sync, do we not have to make sure we set it during this.storageService.onWillSaveState
?
I think when the user triggers the "Continue on" flow, you will have to request all components to persist their state because otherwise it is not guaranteed to be up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once workspace state becomes part of settings sync, do we not have to make sure we set it during this.storageService.onWillSaveState
?
I think when the user triggers the "Continue on" flow, you will have to request all components to persist their state because otherwise it is not guaranteed to be up to date?
I am yielding for git component owners, no objections from my end. |
workspaceState
sync
fyi, I moved the SCM-specific changes into https://github.com/microsoft/vscode/pull/183127/files as I discovered a few necessary fixes while implementing this PR. |
For #179898