-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: to #157015 fix view label command localized #193544
Conversation
Awesome! Looks like you do have a couple of issues still:
From the CI |
src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/editSessions/browser/editSessionsViews.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/userDataSync/browser/userDataSyncViews.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/userDataProfile/browser/userDataProfileImportExportService.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super close! Just a few comments
Copilot-based TS refactors
…deer add workspace tags
add comment help info to diff help dialog
…t-code-mappers-context support getting various document ranges from InteractiveSessionProviders
0328d1f
to
896e2ea
Compare
FYI we are currently in the middle of a release right now, so I want to hold off on getting this in til next week. That way we can let it sit in Insiders for a bit to make sure we don't cause any regressions due to the number of files changed. I think the PR is ready, but I'll approve and merge early next week. |
src/vs/workbench/services/views/test/browser/viewDescriptorService.test.ts
Show resolved
Hide resolved
2687aa3
to
c91a12f
Compare
@yiliang114 I hope you don't hate me for this but I just added a new thing that will make this PR much smaller and have less duplicate strings. I have added a { value: nls.localize({ comment: ['Debug is a noun in this context, not a verb.'], key: 'debugPanel' }, "Debug Console"), original: 'Debug Console' } with a much simpler: nls.localize2({ comment: ['Debug is a noun in this context, not a verb.'], key: 'debugPanel' }, "Debug Console") this function returns an Can you move over to using that so the code is easier to maintain and we don't need to have two of the same string next to each other? I think this won't apply to everything in your PR but probably about 80-90% if the cases. |
Haha, it looks better this way. Let me try again. |
…t-code-mappers-context support getting various document ranges from InteractiveSessionProviders
c91a12f
to
5fd1e02
Compare
Please help me review the code again when you are free @TylerLeonhardt , I did not encountered an error when I compiled locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for taking this on!
@@ -63,13 +64,13 @@ suite('ViewContainerModel', () => { | |||
}); | |||
|
|||
test('empty model', function () { | |||
container = ViewContainerRegistry.registerViewContainer({ id: 'test', title: { value: 'test', original: 'test' }, ctorDescriptor: new SyncDescriptor(<any>{}) }, ViewContainerLocation.Sidebar); | |||
container = ViewContainerRegistry.registerViewContainer({ id: 'test', title: nls.localize2('test', 'test'), ctorDescriptor: new SyncDescriptor(<any>{}) }, ViewContainerLocation.Sidebar); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will be excluded from the actual localization process, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
…193544) * fix: to microsoft#157015 fix view label command localized * chore: save * Fixes microsoft#157015 * Fixes microsoft#157015 * Fixes microsoft#157015 * Fixes microsoft#157015 * Fixes microsoft#157015 * Fixes microsoft#157015 * fix: use nls.localize2 to simplified code * fix: use nls.localize2 to simplified code * fix: use nls.localize2 to simplified code --------- Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Isidor Nikolic <inikolic@microsoft.com> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Ulugbek Abdullaev <ulugbekna@gmail.com>
…tring` (microsoft#195709) Fixes microsoft#195518 regressed in microsoft#193544
Fixes #157015