Don't handle uncaught exceptions during quit

[Tyriar]

This fixes a longstanding issue I've been seeing on macos where quitting Insiders will cause any Code - OSS instance to hang using 100% CPU and the only way to close it is by force killing it via the Activity Monitor

[bpasero]

Curious, do we need to be looking at the other handlers as well or is it really just the one in app.ts:

[bpasero]

I would suggest to rather listen to onWillShutdown as a way to know for sure that we are going down. The quitRequested might be true even though a window still vetos the shutdown.

[deepak1556]

Curious, do we need to be looking at the other handlers as well or is it really just the one in app.ts:

Child processes usually get reaped by the main process, so I think handling only the main process should be fine for now.

I also tried to repro the issue by creating the EIO exception but that didn't cause any loop on exit. @Tyriar if possible can you debug this issue further on your end, basically a couple of things to sanity check

1. Given there are multiple exceptions raised in your case, maybe print the details of the exception and see for which one return undefined actually resolved the issue.
2. Also try moving the return statement down the callstack after entering uncaught exception handler and confirm which code path actually triggers the issue.

[deepak1556]

@alexdima reminded me in standup today that there was a similar issue on server ed63059 trying to do a console on broken pipe caused an endless loop. We still have the same handler on client, can you try the following patch instead to confirm if they are the same issue,

diff --git a/src/main.js b/src/main.js
index 90de17b278b..353985233e0 100644
--- a/src/main.js
+++ b/src/main.js
@@ -28,6 +28,8 @@ const { getUNCHost, addUNCHostToAllowlist } = require('./vs/base/node/unc');
 const product = require('../product.json');
 const { app, protocol, crashReporter, Menu } = require('electron');
 
+process.env['VSCODE_HANDLES_SIGPIPE'] = 'true';
+
 // Enable portable support
 const portable = bootstrapNode.configurePortable(product);
 
diff --git a/src/vs/code/electron-main/app.ts b/src/vs/code/electron-main/app.ts
index 578b00a796e..5ddff4f4c5f 100644
--- a/src/vs/code/electron-main/app.ts
+++ b/src/vs/code/electron-main/app.ts
@@ -364,6 +364,13 @@ export class CodeApplication extends Disposable {
                        }
                });
                process.on('unhandledRejection', (reason: unknown) => onUnexpectedError(reason));
+               process.on('SIGPIPE', () => {
+                       // See https://github.com/microsoft/vscode-remote-release/issues/6543
+                       // We would normally install a SIGPIPE listener in bootstrap.js
+                       // But in certain situations, the console itself can be in a broken pipe state
+                       // so logging SIGPIPE to the console will cause an infinite async loop
+                       onUnexpectedError(new Error(`Unexpected SIGPIPE`));
+               });
 
                // Dispose on shutdown
                this.lifecycleMainService.onWillShutdown(() => this.dispose());