Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't handle uncaught exceptions during quit #208932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't handle uncaught exceptions during quit #208932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/vs/code/electron-main/app.ts
View file
Open in desktop
Expand Up @@ -359,6 +359,11 @@ export class CodeApplication extends Disposable {
// We handle uncaught exceptions here to prevent electron from opening a dialog to the user
setUnexpectedErrorHandler(error => this.onUnexpectedError(error));
process.on('uncaughtException', error => {
// Don't process the exception if exit is happening as it can cause the main process to
// hang while awaiting an IPC reply.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to rather listen to onWillShutdown as a way to know for sure that we are going down. The quitRequested might be true even though a window still vetos the shutdown.

if (this.lifecycleMainService.quitRequested) {
return undefined;
}
if (!isSigPipeError(error)) {
onUnexpectedError(error);
}
Expand Down